In theory PHP should use coerce objects with a __toString method
to string when passing them to a method which has a string-typed
argument, but with the native Exception class this doesn't seem
to be working, so cast explicitly.
Bug: T388171
Change-Id: I310b97164877445837babed2a4c47795f1c2c277
(cherry picked from commit a14ef848f758612ac9d4e8c881ecdbbccf3e1158)
* Update skins/Vector from branch 'REL1_43'
to 9b00e930902b409649c836fd94560867a2ba8f7d
- Localisation updates from https://translatewiki.net.
Change-Id: I5c5928d65464f04b60e704e6a0936ed1f76350ac
* Update skins/MinervaNeue from branch 'REL1_43'
to 3f46718b9dc7676fdff7ef016000cba4773278df
- Localisation updates from https://translatewiki.net.
Change-Id: I0bb41bffeaeda54df1d18964823e2ecb99de568a
* Update extensions/VisualEditor from branch 'REL1_43'
to a33b1d6a45f379b4ddf90e05e0a12c20fdc9eec6
- Localisation updates from https://translatewiki.net.
Change-Id: I3a689f4077c12e2d7f3b0dd90c0eede06d750c85
* Update extensions/WikiEditor from branch 'REL1_43'
to 6888fa0afe1ccc324fa004d5df2befe10125727b
- Localisation updates from https://translatewiki.net.
Change-Id: Ibc5a55be913fb5e1c80c283464fad7a67579c245
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to 6b31118a50245b76a1abec4cba0d64ce30e2a98a
- Localisation updates from https://translatewiki.net.
Change-Id: I4ab8b9b1d87f15586e8a704d29e13dbc770defb6
* Update extensions/TemplateData from branch 'REL1_43'
to 6b5f86a814589e541627369de6a679c43761e509
- Localisation updates from https://translatewiki.net.
Change-Id: I3b83560f8239743641b31604569275b96995b78a
* Update extensions/Scribunto from branch 'REL1_43'
to 8deace10329a9aaabe96728b48869caea17e232a
- Localisation updates from https://translatewiki.net.
Change-Id: I127dcd5630bb5b055ecbf800635768ec8eea0ce1
* Update extensions/ParserFunctions from branch 'REL1_43'
to 7199d854882d6e63ee9250f1ac8ef79188947465
- Localisation updates from https://translatewiki.net.
Change-Id: I1455caab738edd36886f07ae910a8b4eea7b7d55
* Update extensions/OATHAuth from branch 'REL1_43'
to c2960e3f78c9d5f2420debb5418e01ac6d00f06e
- Localisation updates from https://translatewiki.net.
Change-Id: Ie7457c33b865dbc03a199ec1a4a5156893e2093a
* Update extensions/MultimediaViewer from branch 'REL1_43'
to c21ab7d07f6665041c461f120e1e57b8f7ce5f56
- Localisation updates from https://translatewiki.net.
Change-Id: I074741c671495e4e98f4cd212db1f03e086e6fe8
* Update extensions/Math from branch 'REL1_43'
to 72a8df832deb95fec4eaace8675b4cc66b42ac3e
- Localisation updates from https://translatewiki.net.
Change-Id: I7c41c6ec10e0d6a81765f30f60532001c5a75d63
* Update extensions/Linter from branch 'REL1_43'
to acbc3e38b6174665b03214c8a510351445ec6a3c
- Localisation updates from https://translatewiki.net.
Change-Id: I4b10e27e78ec464de839c58ab94a4e8e3e718328
* Update extensions/Gadgets from branch 'REL1_43'
to ac63778ed5738eb52e7a9a32a10e81e73a45f8ea
- Localisation updates from https://translatewiki.net.
Change-Id: Ie477ebd7cd77554bc2eb7258bc08f3561f8f7982
* Update extensions/Echo from branch 'REL1_43'
to 02af04c5e8e4c0494a35e8b3598cfa803c1c87e8
- Localisation updates from https://translatewiki.net.
Change-Id: I4b8eefed6e9ce9e36e2673f1d3509ac7b3165791
* Update extensions/DiscussionTools from branch 'REL1_43'
to cc4f3db0ef68367721266b0ff46415feb981d521
- Localisation updates from https://translatewiki.net.
Change-Id: Ia5fcf3f18fe8e3077f8a5ee721e2413c4dc32596
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 8ccb23bfd3e6d75528a5eb5362b5a1eca517a158
- Localisation updates from https://translatewiki.net.
Change-Id: I6e89915c876b2cf73e547495b1138757a5396f7d
* Update extensions/Cite from branch 'REL1_43'
to 32517d7f1fdd816fdc5da27c31aba0d75bd0d0a3
- Localisation updates from https://translatewiki.net.
Change-Id: I86b2f6ae884a3f9d1b1229e626068d37f1b271ce
* Update extensions/CiteThisPage from branch 'REL1_43'
to 0b1e8bdd657a6ed68ebf60f444fea902e4a986fc
- Localisation updates from https://translatewiki.net.
Change-Id: I3c4450c22ea0c62c7aba413984bec5d81e1dff18
* Update extensions/CategoryTree from branch 'REL1_43'
to 5689942278637bd675f7dc2828acf2d9d3ff0ac1
- Localisation updates from https://translatewiki.net.
Change-Id: I305fe9ca9adf8eeed30ebb268eecda9987e7ed23
* Update extensions/AbuseFilter from branch 'REL1_43'
to bb76bcfc7ecc50970ce8055f219ac532b57a3ca5
- Localisation updates from https://translatewiki.net.
Change-Id: I9ee433a23904a265d832a605657431635ac875b8
Trying to load the session user in an MW_NO_SESSION resulted in
an exception thrown from SessionManager::getSessionFromInfo(),
but User::$mLoadedItems has been set by that point, so if
something catches the exception, future attempts to access that
user object would result in unexpected behavior.
Bug: T388066
Change-Id: Ia3f6d0a96209471db3ce1baf6870a57e1cf1b6b2
(cherry picked from commit a32247211585123565498d2a1e4e54bed6ade6fb)
* Update extensions/ImageMap from branch 'REL1_43'
to 1aa7ea696c546c716a9e6168bfd0edfa73c7ff29
- ImageMap: Bail out if $input is null
Bug: T388464
Change-Id: Ib1706268be419b59d95639cd6dfd412603e19163
(cherry picked from commit dd0a2234bde087e05d89575330c6d31be30d7320)
* Update extensions/InputBox from branch 'REL1_43'
to a8184c4572811cf9df340702e882fe95baa885a0
- InputBoxHooks: Bail out if $input is null
Bug: T388464
Change-Id: I5f109c16a35b69c8a5181c452e09205a71fe7c9c
(cherry picked from commit 54135ce194a89043a95d5157aaba876daddcf87a)
Why:
- Revision meta-data output was failingfor revisions with suppressed
user or comment
What:
- Handle suppressed user and comment gracefully
- add regression test
Bug: T386368
Bug: T387397
Change-Id: Ic6d3fc89d24030f5c3fd422637816de9976fc709
(cherry picked from commit 8c53a15ba0fae2677aa8e28055f06ef557595be6)
Use php build-in support via headers_sent() to get the
relevant file and line for the log message.
Keep the exception for more details.
Change-Id: Ief301710efc19df9b5eaa6d94f138570e3be6290
(cherry picked from commit 8e4a0638bd92620ff216cf8bdd21e3da003130b3)
* Update skins/MinervaNeue from branch 'REL1_43'
to b04c6ac7bcc894644287cb81f67245ad460d3ab6
- Fix logic for when to show the notification circle
This functionality was seemingly broken in I55c18cf72.
The comments in the code declare that the notification circle
should show when there are unseen "notifications" (where a
"notification" is either an "alert" on a "notice), and this
matches user expectations. However the logic as implemented
means we only see the circle when there are unseen "alerts".
Bug: T344029
Change-Id: I91cd5e7703760323c4a6786e8c7a7a00b21e8de2
(cherry picked from commit acb5cb08bfc43e7f43717dba35399fe5233c90d0)
* Update skins/MinervaNeue from branch 'REL1_43'
to 7d8fbb8d8246fd91d38e293b34de2bd57e74f746
- Notifications: Rename variables
Makes it clear the new object being created is the combined
notification represent alerts and notices, instead of
re-using $alert.
Change-Id: I77a1ac19f92bd6e6644ff2630d5b9f3feb40dddd
(cherry picked from commit 2a3ddba2d911b386cdde63a682c767730edd2b75)
Log a warning with preg_replace error instead of passing null to trim.
Bug: T385519
Change-Id: If4ad78168d7899685f4fa1f1d89245c85f0beb0b
(cherry picked from commit 270499b6e1f96f402c852843d446a7946589986b)
* Update vendor from branch 'REL1_43'
to be32300157cf7bfcc88f7c2643426cf55c086682
- Run composer update --no-dev
Changes are present on master in c2b8c1a6.
Change-Id: Ida5b03c41cab91730ac9c75fd7e07eed57954af0
* Update extensions/AbuseFilter from branch 'REL1_43'
to e0f4b20c44893a2b7aca6725c4fc1fe9dac0c83f
- Parser: avoid crash with trailing comma in unrecognised function call
Avoid failing hard, and let SyntaxChecker report the unrecognised
function instead. Also inline the `isFunctionVariadic` method, as it's
only used here. Ideally we wouldn't be checking arity in the first
place, but that is left for a future change.
Bug: T387649
Change-Id: I6303fae037aa4b2464f0da3cdd0b0566a75aa185
(cherry picked from commit 001a809a578ac8193798c22774e797d569ff85a6)
* Update extensions/DiscussionTools from branch 'REL1_43'
to 3067e8052c0ee62f3d1cb6a1f95cde3bb50e7312
- ApiDiscussionToolsEdit: Validate $title before using
Bug: T387640
Change-Id: I591bcfcc9b96ab8bf0f8bc6aba5892ebb6a65842
(cherry picked from commit 3d4e1b5a6979aa9a333682019a4c0c8d9ba2721a)
* Update skins/Vector from branch 'REL1_43'
to a0761a6749801fcc434c3fbb355c7f100cd8d38b
- Localisation updates from https://translatewiki.net.
Change-Id: I9a0685f130a1aab7d5092438611a6b8b92f9bba3
* Update skins/Timeless from branch 'REL1_43'
to 14c4c89dea37b6f06786dc3f3e43d112a903a32f
- Localisation updates from https://translatewiki.net.
Change-Id: I03700e9194a9d1204b17c42c1cfe214b3ae6881e
* Update skins/MinervaNeue from branch 'REL1_43'
to 3104a77b2b54dbfda70c4c318becaf07025110ca
- Localisation updates from https://translatewiki.net.
Change-Id: I1a5c9077a1c29409459bd196ee9e9ab4cd32cc01
* Update extensions/VisualEditor from branch 'REL1_43'
to 773598b8c49eb79710a7c6a3e1201a080b83cce0
- Localisation updates from https://translatewiki.net.
Change-Id: Idddf2c563d297af2bcc06129a59b32b1ecba1ad3
* Update extensions/WikiEditor from branch 'REL1_43'
to 37607928e726801a99a0d864446984c07f61cfdf
- Localisation updates from https://translatewiki.net.
Change-Id: Ic194163900d9543e2bce634519c474a8ec0e2ed3
* Update extensions/TemplateData from branch 'REL1_43'
to 1929a488f84b3c11a9567a2bafa19b6013f6c3d3
- Localisation updates from https://translatewiki.net.
Change-Id: I22ec9a3c31e3cdc1a5423742c67194f1b2efa60f
* Update extensions/PdfHandler from branch 'REL1_43'
to 895c866eedf38502faa5a84c594cdcadc8a7ee67
- Localisation updates from https://translatewiki.net.
Change-Id: If7381a49b468c39e28e87fb5cce6def8a9dd6de4
* Update extensions/OATHAuth from branch 'REL1_43'
to d9d37df2ab0030ec69a8cf971d3f5f1cbc6bc5f4
- Localisation updates from https://translatewiki.net.
Change-Id: Ib047e4eb95b65b0aaf98e3143a17f0e5c5c0288e
* Update extensions/Nuke from branch 'REL1_43'
to 5ac89e3bbb833b9a48961cca360dce779a669809
- Localisation updates from https://translatewiki.net.
Change-Id: Ibe07b5db246278221c91b54a97c630ae9d068cc3
* Update extensions/LoginNotify from branch 'REL1_43'
to 16551ac4152194f3b32dcb09a5faa502b59a9638
- Localisation updates from https://translatewiki.net.
Change-Id: Ibeecd7f93081ca37d6f190293d6bc7f8c9f13cfe
