* Remove extremely old print styles for diffs from commonPrint.css,
added back in r6970. These were created for the old yellow-green-red
diff styles and look terrible now.
* Add new, minimal print styles, that replace background colors with
text decoration (underline for inserted text, line-through for
deleted). Motivation is the same as in r6970: light colored backgrounds
work great on displays, but not very well in black-and-white print.
* Fixed diff styles demo (mediawiki.action.history.diff.html), updated
with print styles and better example.
Bug: 73544
Change-Id: Ibf08fa11f84ac0cf8c7ed4da8af2b8804de6ab6f
* Added a standard getFunctionStats() method for Profilers to return
per function data as maps. This is not toolbar specific like getRawData().
* Cleaned up the interface of SectionProfiler::getFunctionStats() a bit.
* Removed unused cpu_sq, real_sq fields from profiler UDP output.
* Moved getTime/getInitialTime to ProfilerStandard.
Co-Authored-By: Aaron Schulz <aschulz@wikimedia.org>
Change-Id: I266ed82031a434465f64896eb327f3872fdf1db1
We don't want to call Title::makeTitleSafe yet, since that call path
ends up needing the user language, which ends up trying to load the
user object, which ends up back in User::idFromName.
Bug: 54193
Change-Id: I05aacd30be66fe505b5c211113ea938fa82e2492
New changes:
5883e65 Add 'indeterminate' state to progress bar widget
fbe9248 Fix documentation for getRelativeSelectableItem
27f8805 Localisation updates from https://translatewiki.net.
2edfdaa Localisation updates from https://translatewiki.net.
40d08f0 Localisation updates from https://translatewiki.net.
ce8438f Update OOjs to v1.1.3
5721411 Prepare repository for RuboCop
f1abca8 Followup ca6a16f: use parent selector both for hiding and showing windows
Change-Id: I7b49bbc81e9b8ba501f0593daaacf7025f16bf00
The ApiPageSet doesn't know for sure whether it will be resolving
redirects until it is executed, as the revids parameter may override
that (and it can't easily check before being executed because it might
never actually be executed). So ApiQueryInfo needs to just
unconditionally request page_is_redirect and only consider later whether
to try using it.
Bug: 73464
Change-Id: I2297158188dae5476c5b9b5755ea26cf5b8ae487
Make the profiler logging output introduced in Iae11e1e a little nicer.
Stop adding the Profiler::getRawData() information and add the URL and
textual report to the default log message. When testing with a Monolog
logger and Logstash the getRawData output from the Xhprof profiler was
found to be too big to be usable. The default message output was found
to be less informative than desirable when a PSR-3 logger other than
MWLoggerLegacyLogger was used. MWLoggerLegacyLogger implements special
backwards compatible formatting for the profileoutput channel that will
not be effected by this change.
Change-Id: Id326aed4f72a3489fac30661c101ac3bb3af2530
Adds a comment to the top of the generated autoload.php directing
developers to the command to regenerate the file so they may just
copy and paste the command.
Change-Id: If098a1eb51ed732378677215c0e438c73d506697
A reason on a SelectAndOtherField can have two parts, one of the scroll
down box and a free text field. The free text field is actually
unlimited.
This patch allows the maxlength on that field. To respect the concat of
the two parts, also javascript code is added, which adds a dynamic
maxlength to respect also the text from the scroll down box.
The HTMLSelectAndOtherField is only used on Special:Block,
where the maxlength attribute is now set to 255 (length of the database
field ipb_reason).
Change-Id: I5c164b41ab047e7ecf9d92db6eddcc980e2db048
* Make it actually check against the URI length, not file size.
Previous code could produce URIs that edged just over the limit.
* Replace $sizeLimit parameter with $ie8Compat, because that's the
only use case and the file size limit approach was flawed per above,
anyway.
* Remove CSSMin::EMBED_SIZE_LIMIT constant, which is not used anymore.
CSSMin::DATA_URI_SIZE_LIMIT still exists.
* Change code flow to avoid repetition.
* Split off new method, encodeStringAsDataURI(), that does actual
encoding rather than file handling.
Change-Id: I3704404ce831d7e0f6e3a65f23c76f313ad13238
* Remove use of 'error' where it's redundant.
* Remove call to logException from responsibility of MWException.
Call from exception handler instead.
Change-Id: I8764cf5df87b226813c9b9cf99f9b4f3fa4b7c92
It is not called and not working, because it missed return statements.
The validation check is done in getQueryInfo and the message is added in
execute, when needed.
Change-Id: I9acbd2f09a922d5a7d66e8ce55e8d24ae65ab560
I27c488e4008a924117ff6bac2216f148cd5e7abd changed the validation code in
User::getCanonicalName, the # and Title::makeTitleSafe checks now done
there and can be removed here.
Follow-Up: I27c488e4008a924117ff6bac2216f148cd5e7abd
Follow-Up: I88c479cea2bc9d2eab882e0ee8ebcbe2d1dd125e
Follow-Up: I983e3f528491817f9f31f71a92d8d2946ce5941d
Change-Id: I17bf88be6398dc402295264ca9bfd57809c872d7
The default value of 10s is ocasionally failing when loading resources
via RL. Increase to 30s as suggested in the qunit documentation.
http://api.qunitjs.com/QUnit.config/#config-testTimeout
Change-Id: I288db068c8dd1041e0a9be959b3b0c6ddcc7606e
The Maintenance class already does this, though this script does not use it
for the obvious reason that when there is a missing or incorrect autoloader
entry, it may not be possible to initialize MediaWiki.
Hence it is necessary to do that explicitly in this script. Overwriting
autoload.php potentially could disrupt the operation of a production wiki
(the file is truncated when it is opened).
Change-Id: I05d5d4b7c30c4643e71ca5819783627688e15da7
The link text for [[/Foo/]] is `Foo` and the link text for
[[../Foo/]] is `Foo`. So far so good.
But the link text for [[/Foo//]] is `Foo` while the link text
for [[../Foo//]] is `Foo/`. We are stripping all trailing slashes
in the first case, but not the second.
Fix the code so that we strip all trailing slashes in both cases.
Update some of the comments in the code while we are at it.
Change-Id: Id61eacafea9820c404699a7902c8eb8102779516
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 12 all usages have been already removed.
This is the last file in the skins/common/ directory.
Bug: 69277
Change-Id: Id9de81d0efa91fa20dfd10d56a8ae814de43ff6e
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 10 all usages are forward-compatible or have been
already removed.
Bug: 69277
Change-Id: If6a16fb5aa5a826a58c8dec67e3583ccf12761e2
Skin Modern has
dt { margin-bottom: 0.1em }
This generates a legend like a stair.
This change resets the margin to the default for .mw-changeslist-legend.
Change-Id: I3cf0301c1f46cfbb1b9170b18ca4dc52a7a7a903
Right now if a button changes from a light color to a dark color
based on some user action or state change, the button width also
changes, potentially reflowing the content and making the button
move to a completely different location. Both the height and width
need to stay the same (as was discussed in mw-ui standardization
meetings). The effect on the hover-shadow gimmick is virtually
imperceptable.
Bug: 73381
Change-Id: I27edeb4f1317c9d163bc87f54f35a161cdcd686e
